Summary

This corrects the icon font file delivery order, so that modern browsers all get a 16-18Kb font file instead of a 69Kb file (for no reason).

Keymoon is the only person I have *ever* seen advocate the use of .svg over .ttf or .woff, and he has even recently changed his stance: http://icomoon.io/#post/318. Point of fact, *every* other web font provider, *ever*, has always placed .svg last in the stack for very good reason; it's enormous and only required by older, less-capable browsers.

This update means users get the same icon font, but faster and using less bandwidth.

PR: https://github.com/joomla/joomla-cms/pull/1033

Commit details: https://github.com/nternetinspired/joomla-cms/commit/45f74b8ffd5cf80849d107900ee4c18713b31224
Opened On:
22 Apr 2013, 9:12 by Seth Warburton
Closed On:
26 Apr 2013, 17:15
Status:
Fixed in SVN/GitHub

Filed Under

  • First
  • Front End
  • No Platform Implications
  • Second

Responses

Posted on 22 Apr 2013, 9:42 by Nick Savov
Thanks Seth!

I'm moving this from Open to Pending, since we have a pull request.
Posted on 22 Apr 2013, 16:59 by David Hurley
@test

https://github.com/nternetinspired/joomla-cms/commit/45f74b8ffd5cf80849d107900ee4c18713b31224

That works as described. Good to see this being looked at! :) Thanks Seth.

It would be helpful if there were separate PR's for each issue - mainly because I saw the updates to the protostar index and haven't had a chance to fully test the CSS implications (if any).
Posted on 22 Apr 2013, 17:07 by Brian Teeman
Pretty sure I have seen previous issue tracker items about this relating to IE
Posted on 23 Apr 2013, 0:56 by Jean-Marie Simonet
Agree with David, please separate PRs

Any reason to not also propose a similar Icomoon patch for Isis and Hathor?
Posted on 23 Apr 2013, 4:41 by Seth Warburton
Sorry David. I accidentally committed changes to my master branch, so they then show in all other branches I think. I closed the previous PR and re-submitted from a clean repo in a feature branch.

I have also made required changes to Isis and Hathor in addition to Protostar and JUI library. Thanks JM.

Please see: https://github.com/joomla/joomla-cms/pull/1036.diff
Posted on 24 Apr 2013, 1:24 by Roland Dalmulder
@Test: After applying the patch the icons still look fine.
Posted on 24 Apr 2013, 3:46 by Jean-Marie Simonet
Does not media/jui/css/icomoon.css need to also be updated?
Posted on 24 Apr 2013, 4:57 by Seth Warburton
It's never used. TBH, I'm not sure why that file even exists. icomoon.less would be imported by any 3rd party templates using LESS and Isis, Protostar and Hathor all use their own versions of the LESS file (though again I'm not sure why).

It would seem to make sense to have each of those templates simply import icomoon.less from the JUI library instead. Currently we have 4 identical versions of the icomoon.less file.

I'd be happy to make that change if you agree. It would have no impact and reduce the maintenance burden.
Posted on 25 Apr 2013, 5:45 by Peter van Westen
Tested. All fine.
Posted on 25 Apr 2013, 7:23 by David Hurley
@test

Works as described.
Posted on 26 Apr 2013, 17:15 by Mark Dexter
Fixed in master. Thanks!